error dialog is deltachat-rpc-server is not found #4479
Conversation
|
The error is only shown in packaged releases |
|
are there reasons at scale thinkable where this could happen to a normal user that are not related to an AntiVirus program? otherwise, maybe be a bit more broad and on point, also avoiding too technical things in the headline - the normal end-user has no idea an "core library" even exist Your AntiVirus Probably Destroyed this App 😈 |
| // I think we can exit in all the cases, because all errors here are serious | ||
| app.exit(1) |
There was a problem hiding this comment.
Where can I see the list of errors? I'm worried that there might be non-critical errors.
There was a problem hiding this comment.
the list is a comment at the start of the function:
this.serverProcess.on('error', err => {
// The 'error' event is emitted whenever:
// - The process could not be spawned.
// - The process could not be killed.
// - Sending a message to the child process failed.
// - The child process was aborted via the signal option.
// ~ https://nodejs.org/api/child_process.html#event-errorThere was a problem hiding this comment.
Oops, missed that.
Sending a message to the child process failed.
I'm not sure about this. Are we unable to proceed when this happens? Have we seen this happen?
There was a problem hiding this comment.
better exit/crash than undefined behaviour
There was a problem hiding this comment.
That's for sure. But what I'm getting at is that maybe this happens all the time right now, and Delta Chat keeps working fine, without us knowing it.
There was a problem hiding this comment.
It will act weird if messages get lost -> like won't react to user action. Better to fail in those cases that we notice the problem and can fix it IMO.
There was a problem hiding this comment.
I would leave this line out until after 1.52.0.
But if you're sure it's fine, I won't insist.
|
Would be great to merge this even without the wording improvement. This is blocking Rust upgrade and iroh upgrade in the core. |
|
I thought maybe @Simon-Laux Simon will react on the suggestions. Why is this blocking stuff in the core? |
See my comment here: deltachat/deltachat-core-rust#6338 (comment) |
nicodh
changed the title
@link2xt You mean "may have" false positives? We don't expect that to happen, right? |
I'm pretty sure we do. The false-positives pretty much have to do with Rust upgrade, see that issue. |
no don't have opinions on the wording, I did my part: it works for me in packaged builds. I don't care about the exact message/wording. |
It will happen, I built the binaries with new Rust several times and each time there were false positives. But it will be easier to report them once we have binaries with false positives in the releases. |
| @@ -29,6 +29,7 @@ | |||
| - add show_app_in_chat option to webxdc info message context menu #4459 | |||
| - add experimental content protection option (to prevent screenshots and screenrecording the app) #4475 | |||
| - app picker for webxdc apps in attachement menu #4485 | |||
| - add special error dialog for the case that deltachat-rpc-server is not found #4479 | |||
There was a problem hiding this comment.
needs to be rebased before merging, so that the changelog entry is not in the past/already-released version.
closes #4469
needs to also be tested on windows (after installation rename deltachat-rpc-server or delete it to simulate the issue)